hlmem: Add type id to print and allow doing locate on type ids #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows doing locates on types containing spaces
|
I think functions should be identified by their implementation instead of their type, this is in discussion with @yuxiaomao |
|
This is actually less about functions and more about any type that has spaces or that is just very long For example Using heaps' hxsl shaders yields some of these There are also some structs that fit on 8 lines or more in fullscreen 1440p like this hxbit object (not the only one) and also some long types without spaces that are fastidious to type or paste without the id Being able to locate functions before their implementation is available is convenient, but more of an added perk than the initial intention |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows doing locates on types containing spaces
With -c, this displays like this
And then doing
locate #45319yields things referencing theFunction(Void -> Void)type